Fix track tile layout spacing #11929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
added 2 commits
April 23, 2025 14:53
dylanjeffers
approved these changes
Apr 23, 2025
Contributor
dylanjeffers
left a comment
dylanjeffers
left a comment
There was a problem hiding this comment.
looking good, main thing to address is the height prop on user-link
| return ( | ||
| <Flex | ||
| css={{ | ||
| height: spacing.unit5, |
Contributor
There was a problem hiding this comment.
not sure about this one since user-link can be any text component size
| const { data: remixContest } = useRemixContest(id) | ||
|
|
||
| if (!track) return null | ||
| if (!track) return <>{children}</> |
| {imageElement} | ||
| </TrackFlair> | ||
| ) : ( | ||
| imageElement |
Contributor
There was a problem hiding this comment.
when would it not be track?
Author
There was a problem hiding this comment.
CollectionArtwork uses this too so i added the changes ^ to make doubly sure
dharit-tan
approved these changes
Apr 23, 2025
audius-infra
pushed a commit
that referenced
this pull request
Apr 26, 2025
[194d43f] Fix unauth'd accounts fetching public data (#11948) Reed [01b89e2] [PE-6021] Expandable remix contest description on web (#11946) Reed [47be06f] [PE-6049] Remix contest container for mobile web (#11944) KJ [26db394] [PE-5929] Upgrade react-native-collapsible-tab-view (#11811) Dylan Jeffers [8f8e96c] [PE-6022] Mobile expandable remix contest description (#11936) Reed [2e99134] Close 404 page when error is fixed (#11940) Farid Salau [8b5c3b8] [PE-6020] Add submissions section to remix contest container on mobile (#11939) KJ [636118d] Adjust cosign copy post limit (#11938) Isaac Solo [ed9c2e1] [PE-6041] Android remix contest section styling (#11934) Reed [cb0f1d8] Fix missing collection mobile artwork (#11935) Isaac Solo [c75ac99] Add feature flags to tests, fix collection-card (#11907) Dylan Jeffers [20a7174] Address async feedback on wallet UI m1 (#11933) Farid Salau [cc18101] Prevent download-all-button from triggering expand download (#11922) Dylan Jeffers [6b8131a] [PE-6017] Mobile remix contest info section (#11930) Reed [0eb1682] Finish reverting back to favorite saga (#11931) Isaac Solo [d8e9879] [PE-6019] Add submissions tab contest to the remix contest container (#11932) KJ [e1a4561] Fix track tile layout spacing (#11929) Isaac Solo [2a4ad5a] [PE-6015] Update the remix contest drawer on mobile (#11926) KJ [afd52b2] Remove rogue fetchLineupMetadata call (#11928) JD Francis [95ec68e] Add delay to hover card (#11927) Farid Salau [603270a] Add remix contest flair (#11921) Isaac Solo [bd5bda8] Fix user link on comment page (#11919) Farid Salau [e36871e] Add new images to harmony for Wallet UI (#11925) Farid Salau [a77a316] [PE-6034, PE 6033] Fix edit track (#11920) Dylan Jeffers [ebc696a] Update cosign to use generic track flair component (#11911) Isaac Solo [7b01e4b] Fix mobile lineup reset (#11914) Dylan Jeffers [7243c38] [PE-6024] Use real remix eventData in remix contest section (#11916) Reed [6150ac7] Small remix contest modal fix (#11917) KJ [9300b39] Fix remix tracks skeleton issues (#11910) JD Francis [deb0249] [PE-6005] Add mobile wallet UI (#11890) Farid Salau [000d470] Fix stems not showing up in edit form (#11913) KJ [f8c06b4] Update stem dup logic (#11912) KJ [d8c9b65] [PE-6014] Add description and prize fields for remix contests (#11908) KJ [4640162] [PE-6016] Web Remix Contest Section (#11906) Reed [011438a] [PE-5994] Fix mobile lineups (#11905) Dylan Jeffers [36e6f5d] Gate new user-badges in user-link behind wallet-ui flag (#11904) Dylan Jeffers [96f9d7f] Fix remixes scroll bug (#11902) JD Francis [d630cac] Add query client to tests (#11903) Farid Salau [6798bde] Fix remix countdown timer wrong day count (#11901) Reed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing some gaps missed by flair and user link. Also fixed some longstanding issues in spacing in track/collection tile to match designs.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
Ran against web stage.