Repository navigation
[Cataylst] Refactor Platform Services/Dependencies - #121
Merged
Merged
Conversation
4 of 7 tasks
sieren
force-pushed
the
catalyst-platform-services
branch
from
November 3, 2019 11:04
0a60ae5 to
abd9fe4
Compare
Contributor
Author
|
Don’t merge. Gonna fix the build errors. |
sieren
force-pushed
the
catalyst-platform-services
branch
2 times, most recently
from
November 4, 2019 20:41
feaf008 to
0035c47
Compare
Add an extension that splits out platform functionality for third party frameworks depending on the target. This adresses current incompatibilities with MSAppCenter and OneSignal.
Disabling push notification popups until we figure out what to do with OneSignal.
sieren
force-pushed
the
catalyst-platform-services
branch
from
November 4, 2019 20:43
0035c47 to
a3e82b5
Compare
Contributor
Author
|
reping @aure - CI is green now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the way we talk to OneSignal and MSAppCenter.
Since none of these are currently available we are moving those into a Platform-dependent service file that's being called at launch.
This way we keep the AppDelegate clean from Platform-dependent code.
Based on #120 (Please merge that one first)