Open
Conversation
This commit resolves several issues related to audio recording in the Firefox extension, where the UI (microphone animation, audio bands) would become desynchronized with the actual recording state. Key changes include: - Standardized UI state reset logic in `PopupView` for consistent visual transitions between idle, recording, result, and error states. - Ensured `_is_recognizing` and `_is_starting` state flags in `popup.js` are correctly updated, particularly in error paths. - Improved error handling in `content.js` for Firefox recording, including handling `MediaRecorder.onerror` events. - Implemented a timeout mechanism in `popup.js` as a fallback to handle silent failures during Firefox recording (e.g., if the content script becomes unresponsive or the tab is closed). - Added extensive console logging throughout `popup.js` and `content.js` to aid in future debugging and understanding of the execution flow.
Update popup.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.