LEAN-3978 LW-FY25-Q2-S3: Table_element delete suggestion is not showi…

[fwaisi]

…… #427

[zax-assistant]

Published version 1.8.1-LEAN-3978.0

[fwaisi]

Two problems were identified and fixed in the track changes plugin:

• Prosemirror was attempting to insert a table node inside a paragraph node, which is invalid in the document schema. This was causing an error.

• The splitSliceIntoMergedParts function was inadvertently removing paragraph nodes from the slice because it was attempting to merge them with incompatible nodes (like tables). To fix this, I added a node compatibility check before attempting any merge operations:

const firstNodeType = firstChild?.type?.name const nextNodeType = nodes[1]?.type?.name // Only merge when nodes are of the same type const firstMergedNode = openStart > 0 && mergeSides && firstChild && firstNodeType === nextNodeType

I also fixed a logic error in this condition which was incorrectly evaluating to true in all cases.

[IslamJMomani]

Two problems were identified and fixed in the track changes plugin:

• Prosemirror was attempting to insert a table node inside a paragraph node, which is invalid in the document schema. This was causing an error.
• The splitSliceIntoMergedParts function was inadvertently removing paragraph nodes from the slice because it was attempting to merge them with incompatible nodes (like tables). To fix this, I added a node compatibility check before attempting any merge operations:

const firstNodeType = firstChild?.type?.name const nextNodeType = nodes[1]?.type?.name // Only merge when nodes are of the same type const firstMergedNode = openStart > 0 && mergeSides && firstChild && firstNodeType === nextNodeType

I also fixed a logic error in this condition which was incorrectly evaluating to true in all cases.

Are these problems occurring only when pasting the table node, rather than the entire table element? In other words, if the selection includes the whole table element, do any issues still arise?

I’m still under the impression that this is a selection issue that could be handled in the body editor. I’m inviting @mbartenev-atypon to take a look.

[fwaisi]

Two problems were identified and fixed in the track changes plugin:

• Prosemirror was attempting to insert a table node inside a paragraph node, which is invalid in the document schema. This was causing an error.
• The splitSliceIntoMergedParts function was inadvertently removing paragraph nodes from the slice because it was attempting to merge them with incompatible nodes (like tables). To fix this, I added a node compatibility check before attempting any merge operations:

const firstNodeType = firstChild?.type?.name const nextNodeType = nodes[1]?.type?.name // Only merge when nodes are of the same type const firstMergedNode = openStart > 0 && mergeSides && firstChild && firstNodeType === nextNodeType
I also fixed a logic error in this condition which was incorrectly evaluating to true in all cases.

Are these problems occurring only when pasting the table node, rather than the entire table element? In other words, if the selection includes the whole table element, do any issues still arise?

I’m still under the impression that this is a selection issue that could be handled in the body editor. I’m inviting @mbartenev-atypon to take a look.

@IslamJMomani, yes, it's occurring when pasting the table node. Updating the selection as I did in the beginning will fix the issue, but disabling the track-changes plugin will fix the issue as well. So I think we need to decide whether to fix it in the track-changes or in the body-editor.

@mbartenev-atypon, please advise?

[mbartenev-atypon]

I'd say we need to make sure that the selection in the body editor is correct in the first place and we can keep this logic here to issue warnings if anything like that happens but not fix it. E.g.: "attempt to merge incompatible nodes. aborting"