Skip to content
This repository was archived by the owner on Jun 4, 2025. It is now read-only.

Conversation

@mnatsheh
Copy link
Contributor

No description provided.

@mnatsheh mnatsheh marked this pull request as draft May 14, 2025 16:24
@mnatsheh mnatsheh marked this pull request as ready for review June 2, 2025 19:18
Copilot AI review requested due to automatic review settings June 2, 2025 19:18
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the build and dependency workflows to pnpm, updates versions, and removes legacy configs.

  • Deleted the build-specific tsconfig.build.json and adjusted TypeScript commands to use the base config
  • Switched package scripts from yarn to pnpm and bumped the package version for the LEAN-2023 release
  • Removed the Jenkinsfile CI pipeline

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

File Description
tsconfig.build.json Removed build-specific tsconfig file
package.json Updated scripts to use pnpm, added version suffix, bumped deps
Jenkinsfile Deleted legacy Jenkins pipeline
Comments suppressed due to low confidence (3)

tsconfig.build.json:1

  • Deleting this file removes explicit compilerOptions like rootDir, outDir, and exclude patterns. Make sure these settings are ported to tsconfig.json or specified on the CLI to avoid unintended inclusions in your builds.
-{

Jenkinsfile:1

  • [nitpick] The Jenkinsfile has been removed but there is no mention of the new CI approach in the repo docs. Consider updating the README or CI documentation to explain the new pnpm-based workflow.
-pipeline {

package.json:3

  • [nitpick] The -LEAN-2023.1 suffix may not follow your standard SemVer pre-release conventions. Verify that this versioning pattern aligns with your release policy or consider using established pre-release identifiers.
"version": "1.3.14-LEAN-2023.1"

"build:cjs": "tsc --outDir dist/cjs --module commonjs --project tsconfig.build.json",
"build:es": "tsc --outDir dist/es --declarationDir dist/types --declaration --project tsconfig.build.json",
"dev": "yarn build:es --watch",
"build:cjs": "tsc --outDir dist/cjs --module commonjs",
Copy link

Copilot AI Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the --project tsconfig.build.json flag; this drops your custom rootDir, excludes, and types settings. Consider preserving those via --project or migrating them into your base tsconfig.

Suggested change
"build:cjs": "tsc --outDir dist/cjs --module commonjs",
"build:cjs": "tsc --project tsconfig.build.json --outDir dist/cjs --module commonjs",

Copilot uses AI. Check for mistakes.
"dev": "yarn build:es --watch",
"build:cjs": "tsc --outDir dist/cjs --module commonjs",
"build:es": "tsc --outDir dist/es --declarationDir dist/types --declaration",
"dev": "pnpm build:es --watch",
Copy link

Copilot AI Jun 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Using pnpm build:es may not invoke npm lifecycle hooks consistently across environments. Replace with pnpm run build:es --watch to ensure the script runs via the package manager's run command.

Suggested change
"dev": "pnpm build:es --watch",
"dev": "pnpm run build:es --watch",

Copilot uses AI. Check for mistakes.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants