Fix color-related UI not honoring chatbox setting #984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Salanto
reviewed
Jun 25, 2024
| { // chatbox colors | ||
| for (int c = 0; c < max_colors; ++c) | ||
| { | ||
| additive_previous = additive_previous.replace("$c" + QString::number(c), char_color_rgb_list.at(c).name(QColor::HexRgb)); |
Contributor
There was a problem hiding this comment.
Isn't this and the one below literally the same function call or am I missing something here?
What is different here?
Member
Author
There was a problem hiding this comment.
If custom chat boxes are enabled, it pulls data from char_color_rgb_list, otherwise it's pulled from default_color_rgb_list
Salanto
approved these changes
Jun 25, 2024
Contributor
|
The surrounding code looks like spaghetti and the entire colour system needs a genuine overhaul. |
collinxchu
added a commit
to collinxchu/AO2-Client
that referenced
this pull request
Jun 29, 2024
Fix color-related UI not honoring chatbox setting (AttorneyOnline#984)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #983.