The Kaleidoscope - Hell, it's about time. #957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Ported the project to CMake * Android and Mac support dropped for the time being. * Tests, BASS and Discord-RPC are now options * Restructured and reformated the project. * Merged `include` and `src` * Renamed `resource` to `data` * Renamed various files * External libraries headers are no longer included in `src` * Replaced header guards with #pragma once * Multiple refactors (keywords, headers) * Added Qt6 compatibility * Removed various unused functions and headers * Reworked AOPacket * When content is passed to AOPacket, it should be ensured that the content is already decoded. * Encoding/decoding are now static methods. * Fixed various memory leaks * Removed animation code for AOImage * AOImage is always using static images * Simplified ChatLogPiece
Member
|
Bass already was optional at one point but the change was rolled back over looping behaviour |
* Reworked favorite server widget * Renamed `server_type` to `ServerInfo` * Renamed `connection_type` to `ServerConnectionType` * Refactored `AOCharButton` * Reimplemented `AOButton` * Partially reimplemented `AOEmoteButton` * Refactored `AOEvidenceButton`
* Lightly reworked `NetworkManager` * Added new modules to handle various connection types. * TCP * WebSocket * Added general string splitter alias based on Qt version. * Replaced `lobby_constructed` and `courtroom_constructed` * Refactored and partially reimplemented the following classes: * `AOBlipPlayer` * `AOEmotePreview` * `AOMusicPlayer` * `AOSfxPlayer` * `AOTextArea`
This comment format is just tiring for the eyes. Imagine being on 1080p and not being able to read more than 5 method definitions due to comments.
* Reimplemented unit tests and simplified addition of new tests * Minimal support of Qt is now 5.15
TrickyLeifa
added
DOOM#%
Salanto
approved these changes
May 18, 2024
TrickyLeifa
changed the title
TrickyLeifa
changed the title
TrickyLeifa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port to CMake
The project has been ported to CMake, minimum version has been bumped to 3.7.0.
Third-party Options
Some of the third-party libraries (Discord RPC, ...) are to be made optional and become options that you may disable at will before building the program.
Backward-compatibility removal
One of the goal of Kaleidoscope is removal of various backward-compatibility options, it's making it harder and harder to justify older and new clients being compatible with each others.
As more and more functionality within AO2 get introduced, the more the user is to be expected to upgrade their client and server. With the server (akashi) and master server being changed in the future to reflect these changes, it will make it easier overall to make Attorney Online move forward and introduce new functionalities.
Multiple upgrades and improvements are planned for different sections of the client, networking, and so on. The packet system will also receive an overhaul.