Add tests to confirm circular types are ok even if recursing deeply#5
Merged
Add tests to confirm circular types are ok even if recursing deeply#5
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive test coverage for circular type references in TypeScript to verify that deeply recursive type chains maintain their integrity. The test validates that circular references between entities work correctly even with complex nested type relationships.
- Adds test coverage for circular type references with deeply nested entity relationships
- Creates two test entities with many fields to stress-test the type system
- Validates type preservation through complex chain operations and recursive type definitions
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
844bc1d to
66aa5df
Compare
AndreiRaureanu
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1
I could not actually reproduce the issue on TypeScript 5.9 anymore. I did add a test however which validates the ability to deeply recurse and still get the same types out.