-
Notifications
You must be signed in to change notification settings - Fork 53
feat: project specific configuration #411
base: master
Are you sure you want to change the base?
feat: project specific configuration #411
Conversation
Added project specific settings (command, for now) via .lrproject-conf.json
I am thinking in a project config file with almost the same configuration options of the config schema to simplify the rubocop initialization extracting the config file check to a method, and then, override the initial rubocop configuration before use it. |
check for project config file on lint, then, if exists, override the initial rubocop configuration.
- useBundler is not needed anymore, if we want tu run rubocop with bundler we should put it on the command line. - The Config class is a good overprogramming example. It is removed in favour of CommandBuilder, more simple and cool. - Drunken camel case for helpers. - Utility functions extracted to helpers. - SRP aproximation for Rubocop class, we explicitly pass arguments like current directory, etc...
Done. |
Pending to add some tests to check the project specific settings. |
Nice, thank you! |
I am so lazy about this. |
It's OK. But your work is very good and useful. Thank you again, you're great person. I guess, somebody can help if you don't want to add tests (I don't know how to auto-test Atom extensions and I'm pretty busy for learning it right now). |
Thank you, man. |
Added project specific settings via
.lrproject.json
config file: