Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

feat: project specific configuration #411

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

vzamanillo
Copy link
Contributor

@vzamanillo vzamanillo commented Apr 22, 2020

Added project specific settings via .lrproject.jsonconfig file:

{
  "command": "/home/dev/.rvm/gems/ruby-2.5.5/bin/rubocop",
  "disableWhenNoConfigFile": true,
  "fixOnSave": true
}

Added project specific settings (command, for now) via .lrproject-conf.json
@vzamanillo
Copy link
Contributor Author

I am thinking in a project config file with almost the same configuration options of the config schema to simplify the rubocop initialization extracting the config file check to a method, and then, override the initial rubocop configuration before use it.

check for project config file on lint, then, if exists, override the initial rubocop configuration.
- useBundler is not needed anymore, if we want tu run rubocop with bundler we should put it on the command line.
- The Config class is a good overprogramming example. It is removed in favour of CommandBuilder, more simple and cool.
- Drunken camel case for helpers.
- Utility functions extracted to helpers.
- SRP aproximation for Rubocop class, we explicitly pass arguments like current directory, etc...
@vzamanillo vzamanillo marked this pull request as draft April 28, 2020 18:55
@vzamanillo
Copy link
Contributor Author

I am thinking in a project config file with almost the same configuration options of the config schema to simplify the rubocop initialization extracting the config file check to a method, and then, override the initial rubocop configuration before use it.

Done.

@vzamanillo
Copy link
Contributor Author

Pending to add some tests to check the project specific settings.

@AlexWayfer
Copy link

Nice, thank you!

@vzamanillo vzamanillo removed the request for review from Arcanemagus April 30, 2020 07:02
@vzamanillo
Copy link
Contributor Author

Pending to add some tests to check the project specific settings.

I am so lazy about this.

@AlexWayfer
Copy link

I am so lazy about this.

It's OK. But your work is very good and useful. Thank you again, you're great person. I guess, somebody can help if you don't want to add tests (I don't know how to auto-test Atom extensions and I'm pretty busy for learning it right now).

@vzamanillo
Copy link
Contributor Author

I am so lazy about this.

It's OK. But your work is very good and useful. Thank you again, you're great person. I guess, somebody can help if you don't want to add tests (I don't know how to auto-test Atom extensions and I'm pretty busy for learning it right now).

Thank you, man.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants