a rewrite of the Julia side to use StaticLint.jl #119
Conversation
- only 1 julia process (not one per editor) - linting dynamically - feedback on start of environment parsing - faster startup - TODO: shutdown on windows
fixed for unsaved new files (but linting does not show despite messages sent) added message for executable change (terminateServer does not seem to work in .js)
bugfixes for empty files and root parsing do not assume that spawnServer works; ask the user to restart if executable is changed
|
Could you fix the CI as well? If you can fix the CI somehow, I will merge it. Unfortunately, this organization is a closed access organization, and even though I have write-access to this specific repository, I cannot merge this pull request. |
|
I have an improved version now that does on-the-fly linting, and uses only a single server. Still has to somehow kill the process on the Windows side on shutdown. Will try to fix the CI. |
removed julia fork to get default environment
fixed tests
|
@aminya all done now: single server, linting as typing, works on Windows, even that crude unit test passes. Please merge if you can. |
|
@takbal I have been developing linter/linter-ui-default for quite some time now, and yesterday I got admin access to this organization. We can fix the caveats mentioned in the readme. Just let me know if you are interested to help! |
|
@aminya Thanks! Perhaps making a new release would be nice, so it shows up in the official repos. The README should be changed accordingly, like removing the ref to my fork. About help: absolutely, this effort could clearly benefit from a js/Atom expert like yourself - I have just butchered the. js scripts without any real knowledge of how it should be done. Please modify as you wish - I have no big plans on working on it further, unless it breaks. |
|
Oh you did it already while I was typing, awesome. |
|
@takbal Thank you! I will dive into the code once I find some free time in the future. I am planning on making a full-fledged ide-julia based on LSP to consolidate all the code into one all-around package. But for now, the good thing is that the linter works! |
2 participants
This is a fork that replaces Lint.jl with StaticLint.jl. It seems to work for me, but could use more testing.
Please check the readme for changes and caveats.
Technical details:
From 956971b it is an almost complete rewrite to use a single server process. Julia is quite a heavy thing to run one for each editor, and I have decided that it is more important to keep resources low than being just a bit faster. Perhaps it could be still parallelised further by running a dedicated pipe for each editor, rather sharing a single pipe like now, but I feel the speed is already adequate, especially considering that the bottleneck is the symbol server building anyway (that is already spawning in a separate thread).
I still see some problem with lints at end of line being dragged around if enter is pressed on it, but this looks like happening with eslint too, so probably it is an issue with linter.
I know almost nothing of Atom development or js, so the changes are likely ugly there, please revise. I could not make Atom to shut down the child process, so the server exits by polling Atom's PID right now.
Fixes #12