This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
Set CWD and fix ignore handling #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a spec that checks whether any .jshintignore file is being properly handled.
Arcanemagus
force-pushed
the
arcanemagus/set-cwd
branch
3 times, most recently
from
2e5fa65 to
650643b
Compare
Since JSHint can't handle `.jshintignore` files for content sent in via stdin, check this manually using `minimatch`. Also sets the CWD for better automatic resolution of the configuration, since that at least works within JSHint.
Arcanemagus
force-pushed
the
arcanemagus/set-cwd
branch
from
650643b to
96b6436
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since JSHint can't handle
.jshintignorefiles for content sent in viastdin, check this manually usingminimatch.Also sets the CWD for better automatic resolution of the configuration, since that at least works within JSHint.
Fixes #302.