This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
Update to eslint-config-airbnb-base v11.0.0 #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the lint issues exposed, and updates the following to satisfy peerDependencies: * `eslint@^3.12.0` * `eslint-plugin-import@^2.2.0`
Remove several rules that shouldn't have been overridden in the first place.
Re-enable the `comma-dangle` and `semi` rules. The less that we have configured means the less we have to maintain.
The only reason this was brought in was for the type support, but this was never utilized in the code beyond a single type check that meant nothing. Remove it entirely for now as it brings in a lot of extra places for things to break for no benefit.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the lint issues exposed, and updates the following to satisfy
peerDependencies:eslint@^3.12.0eslint-plugin-import@^2.2.0Also brings in a massive simplification of the rules, including removal of
babel-eslintas it wasn't necessary here.Closes #350.
Closes #355.