Look for config in package.json

[max]

JSHint supports a jshintConfig key in package.json but linter-jshint doesn't. I tried to figure out how to get this to work but because the linted file seems to be in a tmp directory without the package.json file JSHint won't automatically pick it up. Unfortunately you can't pass that file in the form of a flag.

Does anyone have suggestions on how to add this functionality?

[iam4x]

Hi @max, didn't know about the new jshintConfig key. I'll drop a PR ;)

[max]

I looked into this issue a little further. jshint scans the cwd for a package.json file if no .jshintrc file is either in the directory or provided with the --config flag. This is however not the case when the Javascript to be linted is passed to stdin – which makes sense. To work around this jshint added the option to pass a filename argument to pretend the content from stdin actually is a file and therefore has a cwd where a package.json can be looked up.

Here is an example that works for me however I can't get this package to work as expected:

cat /some/file.js | jshint --filename=/other/package.json -

I'm not sure if Node's child_process is interfering here or what is going on but if someone can shed some light onto this I'm happy to work on a PR.

Similar discussion for Sublime Text: SublimeLinter/SublimeLinter-jshint#22

[kokarn]

So this is impossible to do if i understand the discussion at sublimelinter?

[harrytruong]

@iam4x I assume you didn't get a chance to look into this issue, so I came up with a fix.

@max I believe you had the right solution. Based on jshint/jshint#1503, adding the --filename argument and passing the file via stdin is the proper fix.

Unfortunately, linter-jshint doesn't use stdin. In fact, linter doesn't allow for stdin at all. (lintFile in Linter will spawn the process, but doesn't allow us hook into stdin.)

I submitted a simple PR to the AtomLinter/Linter repo:

steelbrain/linter#556:
add public method "afterSpawnProcess" to Linter class

Gives subclasses a chance to read or change the child
process, after creating new BufferedProcess while lintFile.

Useful for passing data via stdin (process.process.stdin).

This is a backward compatible improvement.

Assuming that PR is merged, I submitted the proper PR fix here:

AtomLinter/linter-jshint#97
call jshint with stdin, instead of filePath arg

[harrytruong]

@steelbrain has pointed out that this issue was fixed, as of the latest rewrite.

I've confirmed that jshint now properly loads jshintConfig from within package.json:

// package.json
{
    // ...
    "jshintConfig": {
        "esnext": true,
        "undef": true,
        "unused": true,
        "predef": [ "MY_GLOBAL" ]
        // etc...
    }
}

This issue can be closed now.

[max]

Thanks everyone! 🎆 👊