This repository was archived by the owner on Aug 7, 2023. It is now read-only.
fixes #31. send all java files in the project to javac, so it has the… #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it has the source needed to resolve internal type dependencies
…om getFilesEndingWith
|
Sorry this is pretty late... The code looks good. Have you tested this yourself? |
|
Just a side note that this package is doing too much sync operations, keeping in mind that the renderer process is also responsible for drawing minimap and managing other packages and then doing sync operations is a bad idea IMO. How about we do this asyncly, yes it will get a bit complicated but it's worth the benefits IMO. |
|
@kepler0 no worries. yes, I've been running it locally. I haven't hit any issues. |
keplersj
added a commit
that referenced
this pull request
Nov 4, 2015
fixes #31. send all java files in the project to javac, so it has the…
|
I'll publish soon. |
This was referenced Feb 18, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… source needed to resolve internal type dependencies