Skip to content
This repository has been archived by the owner on Aug 27, 2022. It is now read-only.

Commit

Permalink
[XFS] don't call xfs_freesb from xfs_unmountfs
Browse files Browse the repository at this point in the history
xfs_readsb is called before xfs_mount so xfs_freesb should be called after
xfs_unmountfs, too. This means it now happens after a few things during
the of xfs_unmount which all have nothing to do with the superblock.

SGI-PV: 981498

SGI-Modid: xfs-linux-melb:xfs-kern:31835a

Signed-off-by: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>
  • Loading branch information
Christoph Hellwig authored and Lachlan McIlroy committed Aug 13, 2008
1 parent 41b5c2e commit 6203300
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 2 additions & 1 deletion fs/xfs/linux-2.6/xfs_super.c
Original file line number Diff line number Diff line change
Expand Up @@ -1147,6 +1147,7 @@ xfs_fs_put_super(
}

xfs_unmountfs(mp);
xfs_freesb(mp);
xfs_icsb_destroy_counters(mp);
xfs_close_devices(mp);
xfs_qmops_put(mp);
Expand Down Expand Up @@ -1803,7 +1804,7 @@ xfs_fs_fill_super(
WARN_ON(error);

xfs_unmountfs(mp);
goto out_free_fsname;
goto out_free_sb;
}

STATIC int
Expand Down
2 changes: 0 additions & 2 deletions fs/xfs/xfs_mount.c
Original file line number Diff line number Diff line change
Expand Up @@ -1296,8 +1296,6 @@ xfs_unmountfs(
xfs_unmountfs_wait(mp); /* wait for async bufs */
xfs_log_unmount(mp); /* Done! No more fs ops. */

xfs_freesb(mp);

/*
* All inodes from this mount point should be freed.
*/
Expand Down

0 comments on commit 6203300

Please sign in to comment.