Skip to content

Commit

Permalink
[XFS] Fix realtime subvolume expansion, a porting bug b0rked it. Cove…
Browse files Browse the repository at this point in the history
…rity

made me look at this code (bug id #344). We only return with
XFS_ERROR(EINVAL) if mp->m_rtdev_targp is valid and pass it otherwise to
xfs_read_buf() where some function calls later it gets dereferenced by an
assert.

SGI-PV: 954266
SGI-Modid: xfs-linux-melb:xfs-kern:26363a

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Nathan Scott <nathans@sgi.com>
  • Loading branch information
SesterhennEric authored and natoscott committed Jun 27, 2006
1 parent 97dfd70 commit 73024cf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/xfs/xfs_rtalloc.c
Original file line number Diff line number Diff line change
Expand Up @@ -1929,7 +1929,7 @@ xfs_growfs_rt(
/*
* Initial error checking.
*/
if (mp->m_rtdev_targp || mp->m_rbmip == NULL ||
if (mp->m_rtdev_targp == NULL || mp->m_rbmip == NULL ||
(nrblocks = in->newblocks) <= sbp->sb_rblocks ||
(sbp->sb_rblocks && (in->extsize != sbp->sb_rextsize)))
return XFS_ERROR(EINVAL);
Expand Down

0 comments on commit 73024cf

Please sign in to comment.