Skip to content

Commit

Permalink
net: dsa: mv88e6xxx: do not change STP state on port disabling
Browse files Browse the repository at this point in the history
When disabling a port, that is not for the driver to decide what to
do with the STP state. This is already handled by the DSA layer.

Signed-off-by: Vivien Didelot <vivien.didelot@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
vivien authored and davem330 committed Aug 20, 2019
1 parent 0394a63 commit 3903f31
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions drivers/net/dsa/mv88e6xxx/chip.c
Original file line number Diff line number Diff line change
Expand Up @@ -2291,9 +2291,6 @@ static void mv88e6xxx_port_disable(struct dsa_switch *ds, int port)

mv88e6xxx_reg_lock(chip);

if (mv88e6xxx_port_set_state(chip, port, BR_STATE_DISABLED))
dev_err(chip->dev, "failed to disable port\n");

if (chip->info->ops->serdes_irq_free)
chip->info->ops->serdes_irq_free(chip, port);

Expand Down

0 comments on commit 3903f31

Please sign in to comment.