Skip to content

Commit

Permalink
ASoC: rockchip: i2s: fix unbalanced clk_disable
Browse files Browse the repository at this point in the history
mclk is enabled and disabled only in i2s_runtime_{resume,suspend}() and
we ensure that the device is runtime suspended before reaching this
clk_disable_unprepare() call, so it is wrong to call it again here.

Signed-off-by: John Keeping <john@metanate.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
johnkeeping authored and broonie committed Sep 14, 2017
1 parent 7051334 commit 32debfc
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion sound/soc/rockchip/rockchip_i2s.c
Original file line number Diff line number Diff line change
Expand Up @@ -694,7 +694,6 @@ static int rockchip_i2s_remove(struct platform_device *pdev)
if (!pm_runtime_status_suspended(&pdev->dev))
i2s_runtime_suspend(&pdev->dev);

clk_disable_unprepare(i2s->mclk);
clk_disable_unprepare(i2s->hclk);

return 0;
Expand Down

0 comments on commit 32debfc

Please sign in to comment.