Skip to content

Commit

Permalink
logfs get_sb, part 2
Browse files Browse the repository at this point in the history
take setting s_bdev/s_mtd/s_devops to callers of logfs_get_sb_device(),
don't bother passing them separately

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  • Loading branch information
Al Viro committed Oct 29, 2010
1 parent 71a1c01 commit 0d85c79
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 14 deletions.
6 changes: 5 additions & 1 deletion fs/logfs/dev_bdev.c
Original file line number Diff line number Diff line change
Expand Up @@ -339,5 +339,9 @@ int logfs_get_sb_bdev(struct logfs_super *p,
return logfs_get_sb_mtd(p, type, flags, mtdnr, mnt);
}

return logfs_get_sb_device(p, type, flags, NULL, bdev, &bd_devops, mnt);
p->s_bdev = bdev;
p->s_mtd = NULL;
p->s_devops = &bd_devops;

return logfs_get_sb_device(p, type, flags, mnt);
}
11 changes: 6 additions & 5 deletions fs/logfs/dev_mtd.c
Original file line number Diff line number Diff line change
Expand Up @@ -269,13 +269,14 @@ int logfs_get_sb_mtd(struct logfs_super *s,
struct file_system_type *type, int flags,
int mtdnr, struct vfsmount *mnt)
{
struct mtd_info *mtd;
const struct logfs_device_ops *devops = &mtd_devops;

mtd = get_mtd_device(NULL, mtdnr);
struct mtd_info *mtd = get_mtd_device(NULL, mtdnr);
if (IS_ERR(mtd)) {
kfree(s);
return PTR_ERR(mtd);
}
return logfs_get_sb_device(s, type, flags, mtd, NULL, devops, mnt);

s->s_bdev = NULL;
s->s_mtd = mtd;
s->s_devops = &mtd_devops;
return logfs_get_sb_device(s, type, flags, mnt);
}
3 changes: 1 addition & 2 deletions fs/logfs/logfs.h
Original file line number Diff line number Diff line change
Expand Up @@ -627,8 +627,7 @@ void *memchr_inv(const void *s, int c, size_t n);
int logfs_statfs(struct dentry *dentry, struct kstatfs *stats);
int logfs_get_sb_device(struct logfs_super *s,
struct file_system_type *type, int flags,
struct mtd_info *mtd, struct block_device *bdev,
const struct logfs_device_ops *devops, struct vfsmount *mnt);
struct vfsmount *mnt);
int logfs_check_ds(struct logfs_disk_super *ds);
int logfs_write_sb(struct super_block *sb);

Expand Down
7 changes: 1 addition & 6 deletions fs/logfs/super.c
Original file line number Diff line number Diff line change
Expand Up @@ -538,17 +538,14 @@ static void logfs_kill_sb(struct super_block *sb)

int logfs_get_sb_device(struct logfs_super *super,
struct file_system_type *type, int flags,
struct mtd_info *mtd, struct block_device *bdev,
const struct logfs_device_ops *devops, struct vfsmount *mnt)
struct vfsmount *mnt)
{
struct super_block *sb;
int err = -ENOMEM;
static int mount_count;

log_super("LogFS: Start mount %x\n", mount_count++);

super->s_mtd = mtd;
super->s_bdev = bdev;
err = -EINVAL;
sb = sget(type, logfs_sb_test, logfs_sb_set, super);
if (IS_ERR(sb))
Expand All @@ -561,8 +558,6 @@ int logfs_get_sb_device(struct logfs_super *super,
goto err0;
}

super->s_devops = devops;

/*
* sb->s_maxbytes is limited to 8TB. On 32bit systems, the page cache
* only covers 16TB and the upper 8TB are used for indirect blocks.
Expand Down

0 comments on commit 0d85c79

Please sign in to comment.