Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: caching improvements to ci #481

Merged
merged 6 commits into from
Jun 23, 2023

Conversation

lipkau
Copy link
Member

@lipkau lipkau commented Jun 21, 2023

Description

Small improvements to CI pipeline:

  • added PS module caching
  • added upload of test results in ci
  • added yaml file settings

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have added Pester Tests that describe what my changes should do.
  • I have updated the documentation accordingly.

@lipkau lipkau requested review from a team as code owners June 21, 2023 20:00
@lipkau lipkau requested a review from johnheusinger June 21, 2023 21:12
Copy link
Member

@johnheusinger johnheusinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an issue with the CODEOWNERS file - has the ci-managers group been given access to the repo? LGTM aside from that.

Thanks for the invite!

@lipkau lipkau requested a review from a team June 22, 2023 07:21
@lipkau
Copy link
Member Author

lipkau commented Jun 22, 2023

There's an issue with the CODEOWNERS file

what is the issue you found?

has the ci-managers group been given access to the repo?

I did it today, yes

@johnheusinger
Copy link
Member

There's an issue with the CODEOWNERS file

what is the issue you found?

has the ci-managers group been given access to the repo?

I did it today, yes

When I look at the file here, I see the following:

Unknown owner on line 5: make sure the team @atlassianps/ci-managers exists, is publicly visible, and has write access to the repository
…ithub/workflows               @atlassianps/ci-managers
Unknown owner on line 6: make sure the team @atlassianps/ci-managers exists, is publicly visible, and has write access to the repository
…ols/                          @atlassianps/ci-managers
Unknown owner on line 7: make sure the team @atlassianps/ci-managers exists, is publicly visible, and has write access to the repository
…raPS.build.ps1                @atlassianps/ci-managers
Unknown owner on line 8: make sure the team @atlassianps/ci-managers exists, is publicly visible, and has write access to the repository
…SScriptAnalyzerSettings.psd1  @atlassianps/ci-managers

@lipkau lipkau requested a review from johnheusinger June 22, 2023 07:58
Comment on lines 14 to 16
ISSUE_URL: ${{ github.event.pull_request.html_url }}
run: |
gh pr edit $PR --add-reviewer @atlassianps/reviewers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ISSUE_URL: ${{ github.event.pull_request.html_url }}
run: |
gh pr edit $PR --add-reviewer @atlassianps/reviewers
ISSUE_URL: ${{ github.event.pull_request.html_url }}
run: |
gh pr edit $ISSUE_URL --add-reviewer @atlassianps/reviewers

I think you want the variable names on lines 14 and 16 to match

@lipkau lipkau merged commit 109dc34 into master Jun 23, 2023
@lipkau lipkau deleted the feature/caching_improvements_to_ci branch June 23, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants