-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: caching improvements to ci #481
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an issue with the CODEOWNERS file - has the ci-managers
group been given access to the repo? LGTM aside from that.
Thanks for the invite!
what is the issue you found?
I did it today, yes |
When I look at the file here, I see the following:
|
.github/workflows/pr_review.yml
Outdated
ISSUE_URL: ${{ github.event.pull_request.html_url }} | ||
run: | | ||
gh pr edit $PR --add-reviewer @atlassianps/reviewers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ISSUE_URL: ${{ github.event.pull_request.html_url }} | |
run: | | |
gh pr edit $PR --add-reviewer @atlassianps/reviewers | |
ISSUE_URL: ${{ github.event.pull_request.html_url }} | |
run: | | |
gh pr edit $ISSUE_URL --add-reviewer @atlassianps/reviewers |
I think you want the variable names on lines 14 and 16 to match
Description
Small improvements to CI pipeline:
Motivation and Context
Types of changes
Checklist