Update genrules to not use Arules #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the rest of the specialized files classes.
artyomtrityak
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the rest of the specialized files classes as well as the fileio.cpp and fileio.h source files.
Rules output from before my changes has been added to the snapshot tests to verify that the changes didn't break the rules output under as many different situations as I could account for.
There is still a ton of cleanup that could be done in the rules themselves to handle inconsistent use of spacing, extraneous newlines, and some typos that I spotted while going through as well as places that could/should link to subsections which don't do so today.
Ideally, most of these rules would get rewritten via a templating engine so that it was a lot more obvious what text was included/excluded and whether the newlines/punctuation/etc were correct in all variants. That however, was far beyond the reach of this set of changes which was focused solely on removing the use of Arules special file handling.