Move tests to snapshot-tests and enhance them #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snapshot tests kind of suck in general and are more fragile, but they are all we really have right now for testing before the unit test changes and they can still serve some purpose for doing end-to-end testing. This moves the directory to be better named, updates the github workflow to use the new directory/driver script and enhances that script to compare the output to 'expected' output each step of the way.
artyomtrityak
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snapshot tests kind of suck in general and are more fragile, but they are all we really have right now for testing before the unit test changes and they can still serve some purpose for doing end-to-end testing.
This moves the directory to be better named, updates the github workflow to use the new directory/driver script and enhances that script to compare the output to 'expected' output each step of the way.