Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newly added feeds are fetched more often than needed #1431

Closed
flisk opened this issue Jun 12, 2024 · 2 comments
Closed

Newly added feeds are fetched more often than needed #1431

flisk opened this issue Jun 12, 2024 · 2 comments

Comments

@flisk
Copy link

flisk commented Jun 12, 2024

Describe the bug
When adding a new feed to CommaFeed, the feed is fetched in full four separate times as of CommaFeed 4.4.0. Below is the access log of a web server receiving such requests:

192.168.40.10 - - [12/Jun/2024:07:35:35 +0200] "GET /test.xml HTTP/1.1" 200 151431 "-" "CommaFeed/4.4.0 (https://github.com/Athou/commafeed)"
192.168.40.10 - - [12/Jun/2024:07:36:00 +0200] "GET /test.xml HTTP/1.1" 200 151431 "-" "CommaFeed/4.4.0 (https://github.com/Athou/commafeed)"
192.168.40.10 - - [12/Jun/2024:07:36:00 +0200] "GET /test.xml HTTP/1.1" 200 151431 "-" "CommaFeed/4.4.0 (https://github.com/Athou/commafeed)"
192.168.40.10 - - [12/Jun/2024:07:36:00 +0200] "GET /test.xml HTTP/1.1" 200 151431 "-" "CommaFeed/4.4.0 (https://github.com/Athou/commafeed)"

Note the timing of the requests – the first one is sent when the feed is analyzed, while the other three are sent in a short burst when the feed is properly added.

Expected behavior
The feed is only fetched once in full, and subsequent fetches observe HTTP caching semantics.

Environment (please complete the following information):

  • CommaFeed version (or "commafeed.com"): 4.4.0
@Athou
Copy link
Owner

Athou commented Jun 12, 2024

Thanks! I removed one superfluous call already, I'll see what I can do about the other one.

@Athou
Copy link
Owner

Athou commented Sep 14, 2024

Done! I added a small cache to the http client to prevent short burst of requests to the same feed.

@Athou Athou closed this as completed Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants