Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor and image for tournaments #256

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Conversation

userMeh
Copy link
Contributor

@userMeh userMeh commented Jul 18, 2024

Summary 📝

Some refactor for tournaments and images for tournaments

Which part of the repository is impacted ?

  • API
  • Client
  • Admin
  • Documentation
  • CI/CD
  • Other

Test plan 🧪

Screenshots (if appropriate): 📸

@userMeh userMeh added enhancement New feature or request refactor labels Jul 18, 2024
@userMeh userMeh self-assigned this Jul 18, 2024
Copy link

Coverage Report for API (./apps/api)

Status Category Percentage Covered / Total
🟢 Lines 88.63% (🎯 80%) 6685 / 7542
🟢 Statements 88.63% (🎯 80%) 6685 / 7542
🟢 Functions 79.16% (🎯 60%) 19 / 24
🟢 Branches 45.96% (🎯 35%) 262 / 570
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
apps/api/src/handlers/tournaments.ts 65.94% 32.35% 100% 65.94% 49-50, 53-54, 57-58, 68-69, 84-85, 94-95, 107-108, 150-151, 165-166, 181-182, 185-186, 196-197, 208-214, 216-218, 220-221, 233-234, 246-247, 256-257, 288-289, 303-304, 310-313, 315-320, 322-324, 326-328, 330-332, 334-342, 344-346, 348, 350-352, 354-355, 366-367, 372-373, 385-388, 390-395, 397-399, 401, 403-405, 407-413, 415-417, 419-420, 423-426, 428-433, 435-437, 439-445, 447-449, 451-452, 463-464, 479-480, 495-496, 517-518, 532-533, 550-551, 557-558, 586-587, 616-617, 623-625, 631-632, 635-641, 671-672, 678-680, 686-687, 690-697, 722-723
apps/api/src/routes/tournaments.ts 100% 100% 100% 100%
apps/api/src/validators/tournaments.ts 100% 100% 100% 100%
Generated in workflow #448

@userMeh userMeh merged commit b52da44 into main Jul 18, 2024
7 checks passed
@userMeh userMeh deleted the client/feat/image-tournament branch July 18, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant