Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): Logout was not always working properly #242

Merged
merged 5 commits into from
Jul 16, 2024
Merged

Conversation

Jayllyz
Copy link
Contributor

@Jayllyz Jayllyz commented Jul 16, 2024

Summary 📝

Logout was not removing access token from local storage and await was missing so sometimes you had to click 2 times.
Also updated typescript db types.

Which part of the repository is impacted ?

  • API
  • Client
  • Admin
  • Documentation
  • CI/CD
  • Other

Test plan 🧪

Screenshots (if appropriate): 📸

@Jayllyz Jayllyz self-assigned this Jul 16, 2024
@github-actions github-actions bot added the fix label Jul 16, 2024
Copy link

github-actions bot commented Jul 16, 2024

Coverage Report for API (./apps/api)

Status Category Percentage Covered / Total
🟢 Lines 88.64% (🎯 80%) 6656 / 7509
🟢 Statements 88.64% (🎯 80%) 6656 / 7509
🟢 Functions 79.16% (🎯 60%) 19 / 24
🟢 Branches 46.2% (🎯 35%) 262 / 567
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
apps/api/src/index.ts 80.8% 25% 100% 80.8% 34-35, 53-54, 77-91
Generated in workflow #431

@Jayllyz Jayllyz merged commit 7bd7b31 into main Jul 16, 2024
7 checks passed
@Jayllyz Jayllyz deleted the fix/logout-issue branch July 16, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant