feat: enchanced votes with turn for polls #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Coverage Report for API (./apps/api)
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
Jayllyz
reviewed
Jul 9, 2024
| const format = data.map((poll) => ({ | ||
| ...poll, | ||
| results: poll.results.map((option) => ({ ...option, votes: option.votes.length })), | ||
| })); | ||
|
|
||
| const subFormat = subData.map((poll) => ({ |
There was a problem hiding this comment.
Je pense qu'il faudrait mettre cette partie du code sous forme de fonction pour pouvoir l'utiliser à la fois dans getOnePoll et getAllPolls, en cas de modif ca évite d'oublier de changer les 2
There was a problem hiding this comment.
C'est pas pratique de l'exporter en fonction parce que le type de "poll" c'est un type différent de ceux déclaré et ducoup faudrait faire un autre type juste pour lui
userMeh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary 📝
Adds turns and stop conditions for all polls
Which part of the repository is impacted ?
Test plan 🧪
Screenshots (if appropriate): 📸