Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: comments delete cascade #210

Merged
merged 1 commit into from
Jun 29, 2024
Merged

fix: comments delete cascade #210

merged 1 commit into from
Jun 29, 2024

Conversation

Jayllyz
Copy link
Contributor

@Jayllyz Jayllyz commented Jun 29, 2024

Summary 📝

Deletion rules were missing in the comments table when the post or user is deleted.
Added more test case.

Which part of the repository is impacted ?

  • API
  • Client
  • Admin
  • Documentation
  • CI/CD
  • Other

@Jayllyz Jayllyz self-assigned this Jun 29, 2024
Copy link

Coverage Report for API (./apps/api)

Status Category Percentage Covered / Total
🟢 Lines 85.7% (🎯 70%) 5743 / 6701
🟢 Statements 85.7% (🎯 70%) 5743 / 6701
🟢 Functions 75% (🎯 40%) 9 / 12
🟢 Branches 42.22% (🎯 30%) 190 / 450
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
apps/api/src/handlers/blog.ts 88.09% 59.45% 100% 88.09% 46-47, 57-58, 66-67, 69, 84-85, 103-104, 146-147, 176-177, 192-193, 209-210, 220-221, 240-241, 262-263
Generated in workflow #359

@github-actions github-actions bot added the fix label Jun 29, 2024
@Jayllyz Jayllyz merged commit dbaba52 into main Jun 29, 2024
7 of 8 checks passed
@Jayllyz Jayllyz deleted the fix/blog-comments-cascade branch June 29, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant