Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: activities enhancement and activity teams #144

Merged
merged 22 commits into from
May 28, 2024

Conversation

Metololo
Copy link
Contributor

@Metololo Metololo commented May 28, 2024

Summary 📝

This pull request modify the activities routes to allow scheduling and reccurence with exceptions if needed.
It also add teams to the activities and tasks

Which part of the repository is impacted ?

The api is impacted

  • API
  • Client
  • Admin
  • Documentation
  • CI/CD
  • Other

@Metololo Metololo requested a review from Jayllyz May 28, 2024 07:07
@github-actions github-actions bot added the enhancement New feature or request label May 28, 2024
.select('id_user')
.eq('id_activity', activityFound.id_activity);
if (error || !teamMembers) {
return c.json({ error: 'Error while executing requeset' }, 500);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requeset -> request

Copy link
Contributor

@Jayllyz Jayllyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je n'ai pas tout analysé dans le détail mais dans l'ensemble ça paraît good.
Juste attention aux dates dans les tests ça risque de casser un jour une fois dépassé cette datee.

@Metololo
Copy link
Contributor Author

Je n'ai pas tout analysé dans le détail mais dans l'ensemble ça paraît good. Juste attention aux dates dans les tests ça risque de casser un jour une fois dépassé cette datee.

C'est bon car le test d'activité est récurrent à l'infini

@Metololo Metololo merged commit d7eddb1 into main May 28, 2024
7 checks passed
@Metololo Metololo deleted the feat/activity-task-management branch May 28, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants