email notifications improvements with notify roles and groups #2719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Avetisyan <hga@yahooinc.com>
havetisyan
added a commit
that referenced
this pull request
Sep 9, 2024
Signed-off-by: Henry Avetisyan <hga@yahooinc.com>
chandrasekhar1996
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have notifyRoles attribute per role/group which configures ZMS to send email notifications to the configured role members instead of the admin of the domain when new members are added. however, when sending regular expiry notifications, ZMS was not looking at the attribute and always sending to the domain admins. Now, ZMS sends the admin expiry notification to the configured role members and if it's not configured, then to the admins of the domain
when processing members, the server automatically skipped group members from the expiry. however with consolidated notifications even the domain admins didn't receive notifications. Now the server correctly generates expiry notifications for both group members and their respective admins
Contribution Checklist:
Attach Screenshots (Optional)