Support CLAUDE_CONFIG_DIR and checking multiple claude config dirs#51
Open
ndom91 wants to merge 1 commit into
Open
Support CLAUDE_CONFIG_DIR and checking multiple claude config dirs#51ndom91 wants to merge 1 commit into
CLAUDE_CONFIG_DIR and checking multiple claude config dirs#51ndom91 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
inspect review
Triage: 11 entities analyzed | 0 critical, 0 high, 3 medium, 8 low
Verdict: standard_review
Findings (3)
- [low] In
claude_code_projects_dirs_deduplicate_env_and_scan_matchestest, the environment variable is set to an absolute path but the function expects it to be expanded. The test passes an absolute pathhome.join(".claude-personal")which won't match the tilde expansion logic inexpand_home_path, so deduplication won't work as expected. - [low] The
expand_home_pathfunction only handles tilde expansion for paths starting with~or~/, but in the testclaude_code_projects_dirs_deduplicate_env_and_scan_matches, an absolute path is passed. This means the path won't be expanded and deduplication won't occur, causing the test to fail because.claude-personal/projectswill appear twice in the results. - [low] The
expand_home_pathfunction only handles tilde expansion for paths that are valid UTF-8 strings (viapath.to_str()). If the path contains non-UTF-8 characters, it returns the original path unchanged, which could lead to incorrect behavior whenCLAUDE_CONFIG_DIRcontains non-UTF-8 characters on Unix systems.
Reviewed by inspect | Entity-level triage found 0 high-risk changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLAUDE_CONFIG_DIRenvironment variable instead of hardcoding~/.claude/projectsCLAUDE_CONFIG_DIRdirs as well as the default one