-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Map new architecture PoC #4785
base: master
Are you sure you want to change the base?
Conversation
useEffect(() => { | ||
if (region) updateRegion?.(region); | ||
}, [region, updateRegion]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the tile server + vector source is in place, we can completely remove the updateRegion stuff :)
openBottomSheet(() => { | ||
return ( | ||
<ScooterSheet | ||
vehicleId={scooterFeature.properties.id} | ||
onClose={() => { | ||
setSharedState({selectedEntityId: undefined}); | ||
closeBottomSheet(); | ||
}} | ||
onReportParkingViolation={() => {}} | ||
/> | ||
); | ||
}, false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is something very "un-react" about calling functions like this.
I would prefer dispatching an action that would set the app in the desired state 🤔
An interesting approach! |
PoC for this architecture: