Skip to content

Propagate original request user-agent in proxy CONNECT requests #1742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 5, 2021
Merged

Propagate original request user-agent in proxy CONNECT requests #1742

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afadf10
Makes sure custom user-agent is propagated down to CONNECT requests w…
Nov 7, 2020
2835f69
Add a test for custom user agent with proxy
Nov 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Makes sure custom user-agent is propagated down to CONNECT requests w… 
…hen a proxy is in the way, ensuring all outgoing requests bear the correct user agent.
  • Loading branch information
Tom Granot committed Nov 7, 2020
commit afadf10f17831b1cbfb2515b68fe45153c0ac92c
1 change: 1 addition & 0 deletions client/src/main/java/org/asynchttpclient/netty/request/NettyRequestFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ public NettyRequest newNettyRequest(Request request, boolean performConnectReque
if (connect) {
// assign proxy-auth as configured on request
headers.set(PROXY_AUTHORIZATION, request.getHeaders().getAll(PROXY_AUTHORIZATION));
headers.set(USER_AGENT, request.getHeaders().getAll(USER_AGENT));

} else {
// assign headers as configured on request
Expand Down