Fix wrapped mass assignment with unguarded models #431
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
translations_wrapper
config option in combination with a model factory, an SQL error is thrown.This has to do with the fact that eloquent model factories unguard the model before performing a mass assignment. The wrapped attribute is not removed from the attributes array so an attempt is made to insert that into the base model as wel.
This MR fixes that issue. I have accompanied the proposed code with a test to demonstrate its proper functioning.