Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rainbow-delimiters-nvim): event loading #707

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Conversation

jay-babu
Copy link
Contributor

@jay-babu jay-babu commented Jan 5, 2024

addresses: #672

currently rainbow-delimiters do not load properly unless :e is run in the document. using VeryLazy event, it loads properly. I don't fully understand this, but I believe loading the file first then having rainbow-delimiters load causes it to not color everything properly. HiPhish/rainbow-delimiters.nvim#31 (comment). the :e fix seems to be known by the author

📑 Description

ℹ Additional Information

addresses: AstroNvim#672

currently rainbow-delimiters do not load properly unless `:e` is run in the document. using VeryLazy event, it loads properly. I don't fully understand this, but I believe loading the file first then having rainbow-delimiters load causes it to not color everything properly. HiPhish/rainbow-delimiters.nvim#31 (comment). the `:e` fix seems to be known by the author
Copy link

github-actions bot commented Jan 5, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@jay-babu jay-babu changed the title fix(rainbow-delimiters): event loading fix(rainbow-delimiters.nvim): event loading Jan 5, 2024
@jay-babu jay-babu changed the title fix(rainbow-delimiters.nvim): event loading fix(rainbow-delimiters-nvim): event loading Jan 5, 2024
@luxus luxus merged commit 074c182 into AstroNvim:main Jan 10, 2024
17 of 19 checks passed
@jay-babu jay-babu deleted the patch-6 branch January 11, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants