-
-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(full-dadbod): Improve lazy loading #1246
Conversation
also, have dadbod use nerd fonts. be case insensitive add pg to completion which is a file type used for sql tests
Review ChecklistDoes this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist: Proper conventional commit scoping:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a few fixes
does this take care of someone disabled nerd fonts in astronvim? |
@luxus if not, then that should be a separate PR to improve the changelog |
@jay-babu I just cleaned up this PR a bit to use the AstroCore utilities to make everything configurable by the user. I also went ahead and removed the So my guess is it's just not doing what you think it is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks great!
@jay-babu just a heads up, I ended up doing a small refactor. I moved the setup of |
also, have dadbod use nerd fonts. be case insensitive
add pg to completion which is a file type used for sql tests
📑 Description
ℹ Additional Information