Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(full-dadbod): Improve lazy loading #1246

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Conversation

jay-babu
Copy link
Contributor

also, have dadbod use nerd fonts. be case insensitive

add pg to completion which is a file type used for sql tests

📑 Description

ℹ Additional Information

also, have dadbod use nerd fonts. be case insensitive

add pg to completion which is a file type used for sql tests
Copy link

github-actions bot commented Oct 17, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@mehalter mehalter changed the title feat(pack): lazier load full-dadbod feat(full-dadbod): lazier load full-dadbod Oct 22, 2024
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a few fixes

lua/astrocommunity/pack/full-dadbod/init.lua Outdated Show resolved Hide resolved
lua/astrocommunity/pack/full-dadbod/init.lua Outdated Show resolved Hide resolved
@Uzaaft Uzaaft changed the title feat(full-dadbod): lazier load full-dadbod feat(full-dadbod): Improve lazy loading Oct 23, 2024
@luxus
Copy link
Member

luxus commented Oct 23, 2024

does this take care of someone disabled nerd fonts in astronvim?

@mehalter
Copy link
Member

@luxus if not, then that should be a separate PR to improve the changelog

@mehalter
Copy link
Member

@jay-babu I just cleaned up this PR a bit to use the AstroCore utilities to make everything configurable by the user. I also went ahead and removed the completion_ignore_case thing, the only reference to that global variable is in a dead project: https://github.com/nvim-lua/completion-nvim

So my guess is it's just not doing what you think it is

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks great!

@mehalter mehalter merged commit 711efc3 into AstroNvim:main Oct 23, 2024
14 checks passed
@mehalter
Copy link
Member

@jay-babu just a heads up, I ended up doing a small refactor. I moved the setup of pg extension to sql filetype to the SQL pack since that mapping is relatively unrelated to the vim-dadbod setup. The user should rely on the SQL pack to add SQL filetype/language setup

@mehalter
Copy link
Member

99cd785

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants