Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auto-save-nvim)!: swap to okuuva repo #1239

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

ALameLlama
Copy link
Contributor

Closes #1233

📑 Description

Updates to use actively maintained okuuva repo, I also needed to update the way the callbacks work. These are currently broken since it's using autoformat_enabled instead of autoformat

@ALameLlama ALameLlama changed the title Feature/update autosave nvim repo feat(auto-save-nvim): swap to okuuva repo Oct 11, 2024
Copy link

github-actions bot commented Oct 11, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@ALameLlama ALameLlama closed this Oct 11, 2024
@ALameLlama ALameLlama reopened this Oct 11, 2024
@ALameLlama ALameLlama force-pushed the feature/update-autosave-nvim-repo branch from 76e7778 to f40a889 Compare October 11, 2024 06:05
@ALameLlama
Copy link
Contributor Author

I'll still need to do a little more testing, but this should be a drop in replacement to the old callbacks and actually work since before they used the wrong vim options

@ALameLlama ALameLlama force-pushed the feature/update-autosave-nvim-repo branch from f40a889 to 0a7a640 Compare October 11, 2024 12:25
@ALameLlama ALameLlama marked this pull request as ready for review October 11, 2024 12:31
Uzaaft
Uzaaft previously approved these changes Oct 13, 2024
Copy link
Member

@Uzaaft Uzaaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@Uzaaft Uzaaft dismissed their stale review October 13, 2024 10:06

wrong button

Copy link
Member

@Uzaaft Uzaaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@ALameLlama
Copy link
Contributor Author

@Uzaaft Done 🫡. Moved to use astro core autocmds and everything still seems to be working

@ALameLlama
Copy link
Contributor Author

I also might need to update the title of this PR to include that it's a breaking change.

the forked repo is a drop-in replacement if it's just the defaults but if people have extended it, it might break things

@Uzaaft Uzaaft changed the title feat(auto-save-nvim): swap to okuuva repo feat(auto-save-nvim)!: swap to okuuva repo Oct 23, 2024
@Uzaaft Uzaaft merged commit 033dde8 into main Oct 23, 2024
18 checks passed
@Uzaaft Uzaaft deleted the feature/update-autosave-nvim-repo branch October 23, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use okuuva/auto-save.nvim instead of Pocco81/auto-save.nvim
2 participants