Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(neorg): Add default workspace for Neorg #1237

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

haphamdev
Copy link
Contributor

With default workspace, Neorg can start with that workspace. The user does not have to run the command to load the workspace after starting nvim.

With default workspace, Neorg can start with that workspace. The user does not have to run the command to load the workspace after starting nvim.
Copy link

github-actions bot commented Oct 9, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

@haphamdev haphamdev changed the title Update init.lua to add default workspace Update init.lua to add default workspace for Neorg Oct 9, 2024
@haphamdev haphamdev changed the title Update init.lua to add default workspace for Neorg fix(note-taking.neorg): Update init.lua to add default workspace for Neorg Oct 9, 2024
@haphamdev haphamdev changed the title fix(note-taking.neorg): Update init.lua to add default workspace for Neorg fix(neorg): Update init.lua to add default workspace for Neorg Oct 9, 2024
@ALameLlama ALameLlama changed the title fix(neorg): Update init.lua to add default workspace for Neorg fix(neorg): Add default workspace for Neorg Oct 11, 2024
Copy link
Contributor

@ALameLlama ALameLlama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems to match what other configs look like and if notes isn't your default it then you'd still need to enter the command just like before.

@ALameLlama ALameLlama merged commit 05f2e12 into AstroNvim:main Oct 11, 2024
27 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants