Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(game): Add leetcode.nvim #1016

Merged
merged 2 commits into from
May 31, 2024
Merged

feat(game): Add leetcode.nvim #1016

merged 2 commits into from
May 31, 2024

Conversation

Uzaaft
Copy link
Member

@Uzaaft Uzaaft commented May 31, 2024

Closes #971

Copy link

github-actions bot commented May 31, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@Uzaaft Uzaaft requested a review from a team May 31, 2024 07:22
Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Later today I will have some time to add in proper lazy loading if we want to hold off until then

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added and tested lazy loading :shipit:

@mehalter mehalter merged commit f8f6c34 into main May 31, 2024
11 of 12 checks passed
@mehalter mehalter deleted the feat/leetcode branch May 31, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add this plugin leetcode.nvim
2 participants