Skip to content

fix: preserve fetched model metadata after config refresh - #10522

Open
wcqqq1214 wants to merge 1 commit into
AstrBotDevs:masterfrom
wcqqq1214:fix/10476-model-metadata
Open

wcqqq1214 wants to merge 1 commit into
AstrBotDevs:masterfrom
wcqqq1214:fix/10476-model-metadata

Conversation

@wcqqq1214

@wcqqq1214 wcqqq1214 commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #10476.

Saving a model refreshes schema metadata, dropping entries for models not yet configured. Subsequent additions incorrectly default to all capabilities and a zero context limit.

Modifications / 改动点

Prefer metadata retained in the fetched model list, falling back to schema metadata.

  • This is NOT a breaking change. / 这不是一个破坏性变更。

Screenshots or Test Results / 运行截图或测试结果

Verification: fetch models once, save one, then open another without refetching. The second model should retain its advertised capabilities and context limit.

  • Before: reproduced in WebUI; the second model showed 1M in the list but 0 and all capabilities in the dialog.
  • After: local composable checks passed for consecutive additions, failed creation, source switching, and unknown-model defaults. No test files included.
  • Existing dashboard tests: 63 passed; vue-tsc --noEmit, ruff format ., ruff check ., and pnpm run docs:build passed.

Checklist / 检查清单

  • 😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
    / 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。

  • 👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
    / 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”。

  • 📚 I checked the affected WebUI instructions and screenshots in docs/zh and docs/en against the changed navigation, page structure, and labels, and updated them in this PR (or explained why no documentation update is needed). For renamed, moved, or merged entry points, I included an old entry → new entry mapping in the documentation and changelog.
    / 我已对照变化后的 WebUI 入口、页面结构和术语,核对并在本 PR 中更新 docs/zh 和 docs/en 的相关操作说明与截图(或说明无需更新文档的原因)。入口改名、移动或合并时,已在文档和 changelog 中补充 旧入口 → 新入口 对照。

  • 🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in requirements.txt and pyproject.toml.
    / 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到 requirements.txt 和 pyproject.toml 文件相应位置。

  • 😮 My changes do not introduce malicious code.
    / 我的更改没有引入恶意代码。

Summary by Sourcery

Bug Fixes:

  • Preserve metadata advertised by fetched but unconfigured models when retrieving model capabilities and context limits after a configuration refresh.

@wcqqq1214
wcqqq1214 marked this pull request as ready for review October 12, 2026 05:29

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] 获取模型列表后,非首次添加模型时,无法正确获取上游配置

1 participant