new watchfaces: "kitt" and "arc" #10
Conversation
| } | ||
|
|
||
|
|
||
| Connections { |
There was a problem hiding this comment.
Oh, that's right, forgot to remove the localeManager Connection.
Thanks, I'll remove it!
| styleColor: watchFace.arccolor | ||
| } | ||
|
|
||
| ListView { |
There was a problem hiding this comment.
I have the feeling that this is an overly complex solution :P
There was a problem hiding this comment.
Your feeling might be correct.
My Goal was to simplify the variant usages (qml files using Arc { } ) and I might have gone too far.
If you think it's worth it, I'll review and refactor when time allows before opening another pull request.
There was a problem hiding this comment.
Don't worry, I can merge with that. It's just so that you know.
I don't have the time to think of something better either but I'm pretty sure there must be a simpler way.
| @@ -0,0 +1,11 @@ | |||
| Arc { | |||
There was a problem hiding this comment.
I don't see where all those Arc-*.qml items are being used, could you clarify?
There was a problem hiding this comment.
Those are variants that just look a bit different – black vs. white; arc vs. pie chart; seconds visible vs. not visible. They are listed on their own in the watchfaces settings.
There was a problem hiding this comment.
Fair enough, I didn't understand directly. This can be merged as well
|
Hey jgibbon! |
|
Hi FlorentRevest, cheers |
|
Ok, thanks! I've removed the "Connections" (but due to lack of time and my usb dock, I just removed it here via web interface without testing!) from "kitt". |
|
Thank you ! |
new watchfaces: "kitt" and "arc"
These are two new watchfaces:
@eLtMosen has tried them on lenok (thank you!), I've tested dory.
enjoy!