Skip to content

dAppStaking: move extrinsic #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 3, 2025
Merged

dAppStaking: move extrinsic #732

merged 4 commits into from
Mar 3, 2025

Conversation

ipapandinas
Copy link
Contributor

@ipapandinas ipapandinas commented Feb 28, 2025

(+ Governance proxy type)

@ipapandinas ipapandinas requested review from a team as code owners February 28, 2025 14:47
@ipapandinas ipapandinas added the documentation Improvements or additions to documentation label Feb 28, 2025
Copy link

github-actions bot commented Feb 28, 2025

Visit the preview URL for this PR (updated for commit 577f511):

https://astar-docs--pr732-dappstaking-move-8cq9fpko.web.app

(expires Mon, 10 Mar 2025 05:47:38 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f2f13e9b593d211faae6343d67a88fac3fd7268d

Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good!

Just please update the dApp Staking Parameters page as well, and let's merge this.

@@ -191,6 +191,26 @@ If unstake would reduce the staked amount below `MinimumStakeAmount`, everything

Once period finishes, all stakes are reset back to zero. This means that no unstake operation is needed after period ends to _unstake_ funds - it's done automatically.

#### Moving Stake Between Contracts

The moving stake feature allows users to transfer their staked amount between two smart contracts without undergoing the unstake and stake process separately. This feature ensures that the transferred stake remains aligned with the current staking period, but the moved stake is effective in the next era and any bonus eligibility is preserved as long as the conditions for the bonus reward are not violated. Move actions are limited by `MaxBonusSafeMovesPerPeriod` from the protocol configuration.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the config parameter table with the new MaxBonusSafeMovesPerPeriod

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done ✅

@Dinonard Dinonard merged commit b0985d6 into main Mar 3, 2025
3 checks passed
@Dinonard Dinonard deleted the dAppStaking/move branch March 3, 2025 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants