Skip to content

Conversation

bobo-k2
Copy link
Contributor

@bobo-k2 bobo-k2 commented Jul 25, 2025

Pull Request Summary

Updated all Polkadot packages to latest versions.
Motivation:

  • chain errors stopped being propagated to ui logic and because of that the portal displayed all transactions as successful, even if they failed
  • we were 4 @polkadot/api major versions behind

There is one nasty cast to any in Polkasafe code. Any suggestion how to fix is welcome. That's only idea I had since Polkasafe didn't update their package for a very long time and relies on very old @polkadot/api

Downside of this upgrade is that the project build time is slower than before 👎

Check list

  • contains breaking changes
  • adds new feature
  • modifies existing feature (bug fix or improvements)
  • relies on other tasks
  • documentation changes
  • tested on mobile devices

@bobo-k2 bobo-k2 self-assigned this Jul 25, 2025
Copy link

github-actions bot commented Jul 25, 2025

Visit the preview URL for this PR (updated for commit 26b7136):

https://astar-apps--pr1492-feat-polkadot-upgrad-0z4ew552.web.app

(expires Mon, 11 Aug 2025 06:33:00 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: dd76fe72958fe2910fef9d53f0b4539b82b849db

@bobo-k2 bobo-k2 marked this pull request as ready for review July 25, 2025 07:43
Copy link
Contributor

@gtg7784 gtg7784 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for code changes

@bobo-k2
Copy link
Contributor Author

bobo-k2 commented Jul 25, 2025

Thank you, please do some testing when you find a time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants