Skip to content

chore: remove local runtime #1577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ipapandinas wants to merge 4 commits into
base: master
Choose a base branch
from
Open

chore: remove local runtime #1577

ipapandinas wants to merge 4 commits into from

Conversation

@ipapandinas
Copy link
Contributor

@ipapandinas ipapandinas commented Jan 9, 2026 •
edited
Loading

Pull Request Summary

Closes #1567

Rework the local node accordingly:

  • Uses Shibuya runtime with development genesis preset
  • Automatic block production via manual seal
  • Removes aura+grandpa

@ipapandinas ipapandinas added runtime This PR/Issue is related to the topic “runtime”. client This PR/Issue is related to the topic “client”. labels Jan 9, 2026
Dinonard
Dinonard previously approved these changes Jan 12, 2026
View reviewed changes
Copy link
Contributor

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also check astar docs. We might reference this in a few places.

ermalkaleci
ermalkaleci reviewed Jan 12, 2026
View reviewed changes
Copy link
Contributor

@ermalkaleci ermalkaleci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does cargo run -- --dev still works?

@ipapandinas
Copy link
Contributor Author

ipapandinas commented Jan 14, 2026

@ermalkaleci

Does cargo run -- --dev still works?

No, you need to specify --chain shibuya-dev, and you're right, this is bad for our frontier-tests.

@Dinonard I suggest to drop the existing local node but use instead polkadot-omni-node with a minimal NodeSpec that keeps Frontier alive, adding InitBlockImport (for FrontierBlockImport), BuildRpcExtensions (EVM/debug/txpool RPCs), and StartConsensus (Aura/manual-seal in dev).

@Dinonard
Copy link
Contributor

Dinonard commented Jan 14, 2026

No, you need to specify --chain shibuya-dev, and you're right, this is bad for our frontier-tests.

@Dinonard I suggest to drop the existing local node but use instead polkadot-omni-node with a minimal NodeSpec that keeps Frontier alive, adding InitBlockImport (for FrontierBlockImport), BuildRpcExtensions (EVM/debug/txpool RPCs), and StartConsensus (Aura/manual-seal in dev).

If it's simple to do, great.
Even better.

@ipapandinas
Merge branch 'master' into chore/remove-local-runtime
e3affb7 
# Conflicts:
#	Cargo.lock
#	runtime/local/Cargo.toml
@github-actions
Copy link

github-actions bot commented Jan 22, 2026

Code Coverage

Package Line Rate Branch Rate Health
pallets/astar-xcm-benchmarks/src/generic 100% 0% ✔
chain-extensions/unified-accounts/src 0% 0% ❌
pallets/dynamic-evm-base-fee/src 85% 0% ✔
pallets/xc-asset-config/src 57% 0% ➖
chain-extensions/types/assets/src 0% 0% ❌
precompiles/assets-erc20/src 77% 0% ➖
pallets/democracy-mbm/src 30% 0% ❌
precompiles/unified-accounts/src 100% 0% ✔
pallets/static-price-provider/src 91% 0% ✔
pallets/collator-selection/src 82% 0% ✔
chain-extensions/types/unified-accounts/src 0% 0% ❌
pallets/price-aggregator/src 75% 0% ➖
primitives/src 55% 0% ➖
pallets/dapp-staking/src/test 0% 0% ❌
precompiles/dapp-staking/src 89% 0% ✔
precompiles/xcm/src 69% 0% ➖
pallets/dapp-staking/src/benchmarking 95% 0% ✔
pallets/inflation/src 58% 0% ➖
precompiles/dapp-staking/src/test 0% 0% ❌
pallets/unified-accounts/src 80% 0% ✔
pallets/astar-xcm-benchmarks/src 86% 0% ✔
pallets/dapp-staking/src 81% 0% ✔
pallets/dapp-staking/rpc/runtime-api/src 0% 0% ❌
pallets/collective-proxy/src 94% 0% ✔
pallets/ethereum-checked/src 76% 0% ➖
precompiles/substrate-ecdsa/src 74% 0% ➖
chain-extensions/pallet-assets/src 55% 0% ➖
primitives/src/xcm 66% 0% ➖
pallets/astar-xcm-benchmarks/src/fungible 100% 0% ✔
precompiles/dispatch-lockdrop/src 89% 0% ✔
pallets/vesting-mbm/src 87% 0% ✔
precompiles/sr25519/src 69% 0% ➖
Summary 73% (3890 / 5359) 0% (0 / 0) ➖

Minimum allowed line rate is 50%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ermalkaleci ermalkaleci ermalkaleci left review comments

@Dinonard Dinonard Dinonard left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

client This PR/Issue is related to the topic “client”. runtime This PR/Issue is related to the topic “runtime”.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Local runtime removal

4 participants

@ipapandinas @Dinonard @ermalkaleci