Skip to content

Add comment about auto exportRuntime in compiler.md #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2022

Conversation

MaxGraey
Copy link
Member

@MaxGraey MaxGraey commented Aug 7, 2022

@MaxGraey MaxGraey requested a review from dcodeIO August 7, 2022 12:15
@MaxGraey MaxGraey added the enhancement New feature or request label Aug 7, 2022
@dcodeIO
Copy link
Member

dcodeIO commented Aug 7, 2022

Looks like the description should first be added to the CLI options, and then copied to documentation?

@MaxGraey
Copy link
Member Author

MaxGraey commented Aug 7, 2022

Yeah. Good point!

Comment on lines +99 to +100
--exportRuntime Always exports the runtime helpers (__new, __collect, __pin etc.).
Automatically determined when generation of --bindings is enabled.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only noticing now: I think the lines here have become (too) long?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I guess it's ok

@MaxGraey MaxGraey merged commit 3396db3 into AssemblyScript:main Aug 8, 2022
@MaxGraey MaxGraey deleted the upd-exportRuntime-desc branch August 8, 2022 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants