Fix missing TS1110 on function signatures with one parameter #823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
potentially fixes #822
As mentioned in #822 (comment) we were missing a diagnostic here in the
(identifier)case, which is ambiguous in that it can be either a parenthesized or a function type without parsing further. The fix is a bit awkward because the parser cannot look ahead more than one token, so it remembers the potentially erroneous parameter and issues the diagnostic once it is sure that it is dealing with a function type. Also adds parameters with an omitted type to the AST fwiw (serialization purposes maybe).