Add Array#join and Array#toString + dtoa #275
Conversation
MaxGraey
changed the title
std/assembly/array.ts
Outdated
| } from "./internal/array"; | ||
|
|
||
| import { itoa } from "./internal/itoa"; | ||
| import { dtoa } from "./internal/dtoa"; |
There was a problem hiding this comment.
Could maybe make this internal/number holding all the number compatibility code
There was a problem hiding this comment.
I think parse<T> should be also move to internal/number. WDYT?
std/assembly/array.ts
Outdated
| var hasSeparator = separator.length != 0; | ||
| if (value instanceof bool) { | ||
| for (let i = 0; i < lastIndex; ++i) { | ||
| result += loadUnsafe<T,T>(buffer, i) ? "true" : "false"; |
There was a problem hiding this comment.
Without a GC, string concatenation leaves behind unreferenced instances and building the string from scratch using low-level ops might be a better strategy there. Ideally, just the final step, when appending lastIndex, makes a proper string that can be handled by GC.
There was a problem hiding this comment.
For itoa and especially dtoa this pretty problematic because I don't forecast actual string length produced after stringify and can't preallocate one buffer. But I could allocate one buffer with maximum possible size. WDYT?
There was a problem hiding this comment.
Also this will require two pass (interation through array) logic
|
Great, thank you! :) |
Array#joinmethod;Array#toStringmethod;dtoamethod;dtoaanditoatointernal/numberfile;itoaand add its generic and streaming versions;Array#includeswhich now reusingArray#indexOf;DONE
dtoadtoaArray#joinArray#join