Add TypedArray#fill #274
Merged
Add TypedArray#fill #274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGraey
commented
Sep 19, 2018
std/assembly/internal/typedarray.ts
Outdated
| var buffer = this.buffer; | ||
| var byteOffset = this.byteOffset; | ||
| var len = this.length; | ||
| start = start < 0 ? max(len + start, byteOffset >> alignof<T>()) : min(start, len); |
There was a problem hiding this comment.
Not sure about lower and upper limits. Need more tests
There was a problem hiding this comment.
Should be possible to ignore byteOffset up to the point where the memory.fill operation is used, like with a normal array. That's just the offset into the backing buffer when accessing it internally.
dcodeIO
reviewed
Oct 11, 2018
std/assembly/internal/typedarray.ts
Outdated
| memory.fill( | ||
| changetype<usize>(buffer) + start + byteOffset + AB_HEADER_SIZE, | ||
| <u8>value, | ||
| <usize>(end - start) |
There was a problem hiding this comment.
I think it's necessary to make sure that end >= start, otherwise this might overflow and copy like all the memory?
There was a problem hiding this comment.
e.g. fill(0xff, 1, 0) on an Uint8Array: start = 1, end = 0, <usize>(0 - 1) = 0xffffffff
|
Looking good with the conflicts resolved |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.