Skip to content

Push to the inline stack after compiling arguments #2527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2022
Merged

Push to the inline stack after compiling arguments #2527

merged 1 commit into from
Oct 3, 2022

Conversation

CountBleck
Copy link
Member

This change allows calls like a(a(a(1))) to be @inlined properly.

  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

@MaxGraey MaxGraey requested a review from dcodeIO October 2, 2022 19:29
dcodeIO
dcodeIO approved these changes Oct 2, 2022
View reviewed changes
Copy link
Member

@dcodeIO dcodeIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you add a comment to make sure this isn't accidentally moved again?

@CountBleck
Push to the inline stack after compiling arguments
43e463b 
This change allows calls like `a(a(a(1)))` to be @inlined properly.
@CountBleck CountBleck requested a review from dcodeIO October 2, 2022 22:09
@dcodeIO dcodeIO merged commit dc797a4 into AssemblyScript:main Oct 3, 2022
@dcodeIO
Copy link
Member

dcodeIO commented Oct 3, 2022

Thanks!

@CountBleck CountBleck deleted the defer-inline-push branch October 6, 2022 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcodeIO dcodeIO Awaiting requested review from dcodeIO

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CountBleck @dcodeIO