Skip to content

fix: Add missing type for i64_signbit input argument #2454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 21, 2022
Merged

fix: Add missing type for i64_signbit input argument #2454

merged 2 commits into from
Aug 21, 2022

Conversation

JairusSW
Copy link
Contributor

  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

Fixed a type def for i64_signbit in

assemblyscript/src/glue/js/i64.d.ts

Line 51 in 3a5b51d

declare function i64_signbit(value): boolean;

@MaxGraey
Copy link
Member

Please add youself to NOTICE file

@MaxGraey MaxGraey changed the title Fix: i64_signbit type def fix: Add missing type for i64_signbit input argument Aug 19, 2022
@JairusSW
Copy link
Contributor Author

@MaxGraey, done

@MaxGraey MaxGraey merged commit beda866 into AssemblyScript:main Aug 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcodeIO dcodeIO dcodeIO approved these changes

@MaxGraey MaxGraey MaxGraey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JairusSW @MaxGraey @dcodeIO