Skip to content

[NFC] Refactor fill methos of all arrays #2406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 6, 2022
Merged

[NFC] Refactor fill methos of all arrays #2406

merged 8 commits into from
Aug 6, 2022

Conversation

MaxGraey
Copy link
Member

@MaxGraey MaxGraey commented Aug 4, 2022

Add new FILL macro in util/bytes and reuse it for Array#fill, TypeArray#fill and StaticArray#fill

  • I've read the contributing guidelines
  • I've added my name and email to the NOTICE file

@MaxGraey MaxGraey requested a review from dcodeIO August 4, 2022 19:52
dcodeIO
dcodeIO reviewed Aug 6, 2022
View reviewed changes
@MaxGraey MaxGraey merged commit aec8eb3 into AssemblyScript:main Aug 6, 2022
@MaxGraey MaxGraey deleted the generalize-fill branch August 6, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcodeIO dcodeIO dcodeIO left review comments

Assignees
No one assigned
Labels
enhancement standard library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaxGraey @dcodeIO